fixup

Nexesenex · Jan 14, 2025 · 0b78780 · 0b78780
1 parent 0dba9e5
commit 0b78780
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 310 deletions.
diff --git a/ggml/src/ggml-backend.cpp b/ggml/src/ggml-backend.cpp
@@ -333,7 +333,6 @@ enum ggml_status ggml_backend_graph_compute_async(ggml_backend_t backend, struct
 }
 
 bool ggml_backend_supports_op(ggml_backend_t backend, const struct ggml_tensor * op) {
-    // GGML_ASSERT(ggml_backend_dev_supports_op(backend->device, op));
     return ggml_backend_dev_supports_op(backend->device, op);
 }
 

diff --git a/ggml/src/ggml-cpu/ggml-cpu.c b/ggml/src/ggml-cpu/ggml-cpu.c
@@ -6966,6 +6966,8 @@ static void ggml_compute_forward_rms_norm_f32(
     float eps;
     memcpy(&eps, dst->op_params, sizeof(float));
 
+    GGML_ASSERT(eps > 0.0f);
+
     // TODO: optimize
     for (int64_t i03 = 0; i03 < ne03; i03++) {
         for (int64_t i02 = 0; i02 < ne02; i02++) {

diff --git a/ggml/src/ggml.c b/ggml/src/ggml.c
@@ -3294,7 +3294,6 @@ struct ggml_tensor * ggml_get_rows(
 }
 
 // ggml_get_rows_back
-// TODO reorder arguments to be consistent with other _back ops
 
 struct ggml_tensor * ggml_get_rows_back(
         struct ggml_context * ctx,

diff --git a/src/llama-model-saver.cpp b/src/llama-model-saver.cpp
diff --git a/src/llama-model-saver.h b/src/llama-model-saver.h
-Original file line number
+Diff line change
@@ Expand Up @@
     }
     bool ggml_backend_supports_op(ggml_backend_t backend, const struct ggml_tensor * op) {
-        // GGML_ASSERT(ggml_backend_dev_supports_op(backend->device, op));
         return ggml_backend_dev_supports_op(backend->device, op);
     }
@@ Expand Down @@