Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

tooltip使用popper定位 #369

Merged
merged 4 commits into from
Nov 28, 2018
Merged

tooltip使用popper定位 #369

merged 4 commits into from
Nov 28, 2018

Conversation

lusssn
Copy link
Collaborator

@lusssn lusssn commented Nov 22, 2018

close #244

@lusssn lusssn requested review from liufei, wjeek and menggeNiu November 22, 2018 13:30
@liufei
Copy link
Member

liufei commented Nov 22, 2018

@menggeNiu
Copy link
Collaborator

image
position为top的时候,在此临界点,箭头方向向上是不是好点

menggeNiu
menggeNiu previously approved these changes Nov 27, 2018
tooltipNode.appendChild(innerNode)
tooltipContentNode.appendChild(arrowNode)
tooltipContentNode.appendChild(innerNode)
tooltipNode.appendChild(tooltipContentNode)

document.body.appendChild(tooltipNode)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

能否通过portal + jsx实现,避免直接操作DOM?

@lusssn
Copy link
Collaborator Author

lusssn commented Nov 28, 2018

用portal改造tooltip之后,不得不给children外包一层div元素。
这是一个问题点,有改变原页面布局的风险。

@liufei liufei merged commit c277fe8 into master Nov 28, 2018
@liufei liufei deleted the tooltip-enhance-244 branch November 28, 2018 09:04
@liufei liufei restored the tooltip-enhance-244 branch November 29, 2018 03:48
@liufei liufei deleted the tooltip-enhance-244 branch November 29, 2018 04:52
liufei added a commit that referenced this pull request Nov 29, 2018
liufei added a commit that referenced this pull request Nov 29, 2018
* Revert "Fix tooltip wrapper (#388)"

This reverts commit a27e6b9.

* Revert "tooltip使用popper定位 (#369)"

This reverts commit c277fe8.

* Bump version to 2.0.5-alpha.3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip改用popper.js实现
4 participants