add Image type and subtypes GrayScaleImage, RGBImage, RGBAImage #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add Image to core.base * add GrayscaleImage, RGBImage, and RGBAImage to core.image * add pynwb support for Image, Images, GrayscaleImage, RGBImage, and RGBAImage TODO: add test
* make image subtypes groups instead of datasets * add doc fields to schema * add tests for all types
bendichter
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #693 +/- ##
==========================================
+ Coverage 74.51% 74.57% +0.05%
==========================================
Files 58 58
Lines 6753 6776 +23
Branches 1393 1398 +5
==========================================
+ Hits 5032 5053 +21
- Misses 1328 1332 +4
+ Partials 393 391 -2
Continue to review full report at Codecov.
|
oruebel
previously requested changes
Oct 30, 2018
oruebel
previously approved these changes
Oct 30, 2018
|
I guess I was too soon with approving it. Looks like the CI fails. But other than the failed tests it looked good to me. |
bendichter
dismissed
oruebel’s stale review
thanks. I have addressed your comments
|
Do we want to enforce that |
ajtritt
reviewed
Oct 30, 2018
|
Yeah that was my original plan but I didn't know how to get Images to work
with it
…On Tue, Oct 30, 2018, 4:14 PM Andrew Tritt ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/pynwb/data/nwb.base.yaml
<#693 (comment)>
:
> @@ -91,6 +91,24 @@ groups:
- neurodata_type_def: NWBDataInterface
neurodata_type_inc: NWBContainer
doc: An abstract data type for differentiating experimental data from metadata
+- neurodata_type_def: Image
Why is Image a group and not a dataset? Making a group requires the
additional dataset. This doubles the number of objects need to store an
image
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#693 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAziEhV_EvZLCEXDYvi74ar-j9LBW3rKks5uqLMRgaJpZM4YCgKw>
.
|
|
@bendichter I just submitted a PR to this branch. I thought seeing the diff would be easier than trying to explain it over text. |
* make Image basetype a dataset * move Image subtypes to datasets * fix dataset specs
|
@ajtritt can you review this? |
ajtritt
requested changes
Oct 31, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fix NeurodataWithoutBorders/nwb-schema#143, fix NeurodataWithoutBorders/nwb-schema#129
Checklist
flake8from the source directory.#XXXnotation whereXXXis the issue number ?