Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SpatialSeries to have bounds field #1869

Merged
merged 19 commits into from
May 2, 2024
Merged

Update SpatialSeries to have bounds field #1869

merged 19 commits into from
May 2, 2024

Conversation

mavaylon1
Copy link
Collaborator

@mavaylon1 mavaylon1 commented Mar 25, 2024

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

Add test to SpatialSeries for bounds to make sure everything passes.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (78ebc86) to head (e80273b).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1869   +/-   ##
=======================================
  Coverage   92.01%   92.02%           
=======================================
  Files          27       27           
  Lines        2619     2620    +1     
  Branches      685      685           
=======================================
+ Hits         2410     2411    +1     
  Misses        139      139           
  Partials       70       70           
Flag Coverage Δ
integration 73.24% <100.00%> (+0.43%) ⬆️
unit 83.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1
Copy link
Collaborator Author

Review Notes:

We talked about the idea of validating data according to the bounds (if provided); however, we decided to not validate due to performance. As result, the only test added is to ensure the bounds field is mapped correctly to the spec.

@mavaylon1 mavaylon1 marked this pull request as ready for review March 30, 2024 19:26
@mavaylon1 mavaylon1 requested a review from rly April 2, 2024 16:25
@rly rly changed the title Update SpatiesSeries to have bounds field Update SpatialSeries to have bounds field Apr 25, 2024
@rly
Copy link
Contributor

rly commented Apr 25, 2024

Sorry for the late review of this @mavaylon1 . Could you add a roundtrip test with the new field?

@mavaylon1 mavaylon1 self-assigned this May 1, 2024
@mavaylon1 mavaylon1 added this to the 2.7.0 milestone May 1, 2024
@mavaylon1
Copy link
Collaborator Author

Sorry for the late review of this @mavaylon1 . Could you add a roundtrip test with the new field?

Done. Sorry for the delay.

src/pynwb/behavior.py Outdated Show resolved Hide resolved
@rly rly enabled auto-merge (squash) May 2, 2024 23:00
@rly rly merged commit f136410 into dev May 2, 2024
21 of 23 checks passed
@rly rly deleted the spatial_2.7 branch May 2, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants