-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.5.0/ Update ExternalResources to HERD #1754
Conversation
@oruebel Should we do a minor release for HDMF for this PR or wait till the first stage of Termset is done and merged. |
Could we move this along? Having the dev branches out of sync between HDMF and PyNWB makes it difficult to develop new features. In the future, would it be possible to prepare these branches at the same time and merge them at more or less the same time? |
The plan is to do a release this week. It took time to get a review for certain merges in HDMF. My hope is that all the merges can get in today on the HDMF side so I can do a release. Then tomorrow I'll do a fix on the hdmf version here. |
Getting things to match exactly is tricky, but I agree, we'll try to merge these kind of interdependent PRs in a closer order in the future. This one was in part my fault for being to quick with approvals. |
Codecov Report
@@ Coverage Diff @@
## dev #1754 +/- ##
=======================================
Coverage 91.98% 91.98%
=======================================
Files 27 27
Lines 2608 2608
Branches 681 681
=======================================
Hits 2399 2399
Misses 134 134
Partials 75 75
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Prepare for release of PyNWB [2.5.0]
Before merging:
requirements.txt
,requirements-dev.txt
,requirements-doc.txt
,requirements-min.txt
,environment-ros3.yml
, andsetup.py
as needed.Legal.txt
,license.txt
,README.rst
,docs/source/conf.py
,and any other locations as needed
setup.py
as neededREADME.rst
as neededsrc/pynwb/nwb-schema
submodule as needed. Check the version number and commit SHA manuallyCHANGELOG.md
and any other docs as needed(
python test.py -v -p -i -b -w -r > out.txt 2>&1
)make clean
,make html
)build docs for new branch): https://readthedocs.org/projects/pynwb/builds/
Motivation
What was the reasoning behind this change? Please explain the changes briefly.
This is to update pynwb with the name update for ExternalResources in HDMF and hdmf-common-schema.
How to test the behavior?
Run the unit tests
Checklist
flake8
from the source directory.