Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.5.0/ Update ExternalResources to HERD #1754

Merged
merged 14 commits into from
Aug 18, 2023
Merged

Release 2.5.0/ Update ExternalResources to HERD #1754

merged 14 commits into from
Aug 18, 2023

Conversation

mavaylon1
Copy link
Collaborator

@mavaylon1 mavaylon1 commented Aug 10, 2023

Prepare for release of PyNWB [2.5.0]

Before merging:

  • Major and minor releases: Update package versions in requirements.txt, requirements-dev.txt,
    requirements-doc.txt, requirements-min.txt, environment-ros3.yml, and setup.py as needed.
  • Check legal file dates and information in Legal.txt, license.txt, README.rst, docs/source/conf.py,
    and any other locations as needed
  • Update setup.py as needed
  • Update README.rst as needed
  • Update src/pynwb/nwb-schema submodule as needed. Check the version number and commit SHA manually
  • Update changelog (set release date) in CHANGELOG.md and any other docs as needed
  • Run tests locally including gallery, validation, and streaming tests, and inspect all warnings and outputs
    (python test.py -v -p -i -b -w -r > out.txt 2>&1)
  • Test docs locally (make clean, make html)
  • Push changes to this PR and make sure all PRs to be included in this release have been merged
  • Check that the readthedocs build for this PR succeeds (build latest to pull the new branch, then activate and
    build docs for new branch): https://readthedocs.org/projects/pynwb/builds/

Motivation

What was the reasoning behind this change? Please explain the changes briefly.
This is to update pynwb with the name update for ExternalResources in HDMF and hdmf-common-schema.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Run the unit tests

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@mavaylon1
Copy link
Collaborator Author

mavaylon1 commented Aug 10, 2023

@oruebel Should we do a minor release for HDMF for this PR or wait till the first stage of Termset is done and merged.

@bendichter
Copy link
Contributor

bendichter commented Aug 17, 2023

Could we move this along? Having the dev branches out of sync between HDMF and PyNWB makes it difficult to develop new features. In the future, would it be possible to prepare these branches at the same time and merge them at more or less the same time?

@mavaylon1
Copy link
Collaborator Author

Could we move this along? Having the dev branches out of sync between HDMF and PyNWB makes it difficult to develop new features. In the future, would it be possible to prepare these branches at the same time and merge them together?

The plan is to do a release this week. It took time to get a review for certain merges in HDMF. My hope is that all the merges can get in today on the HDMF side so I can do a release. Then tomorrow I'll do a fix on the hdmf version here.

@oruebel
Copy link
Contributor

oruebel commented Aug 17, 2023

would it be possible to prepare these branches at the same time and merge them at more or less the same time?

Getting things to match exactly is tricky, but I agree, we'll try to merge these kind of interdependent PRs in a closer order in the future. This one was in part my fault for being to quick with approvals.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #1754 (3ae0fbe) into dev (8eb9a36) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #1754   +/-   ##
=======================================
  Coverage   91.98%   91.98%           
=======================================
  Files          27       27           
  Lines        2608     2608           
  Branches      681      681           
=======================================
  Hits         2399     2399           
  Misses        134      134           
  Partials       75       75           
Flag Coverage Δ
integration 71.24% <50.00%> (ø)
unit 83.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/pynwb/__init__.py 78.48% <100.00%> (ø)
src/pynwb/file.py 88.88% <100.00%> (ø)
src/pynwb/resources.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mavaylon1 mavaylon1 changed the title Update ExternalResources to HERD Release 2.5.0/ Update ExternalResources to HERD Aug 18, 2023
@mavaylon1 mavaylon1 marked this pull request as ready for review August 18, 2023 21:53
@mavaylon1 mavaylon1 self-assigned this Aug 18, 2023
@mavaylon1 mavaylon1 requested a review from rly August 18, 2023 21:54
@mavaylon1 mavaylon1 merged commit 68c4f56 into dev Aug 18, 2023
@rly rly deleted the herd branch December 14, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants