Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance LabMetaData docstring #1546

Merged
merged 6 commits into from
Sep 1, 2022
Merged

Enhance LabMetaData docstring #1546

merged 6 commits into from
Sep 1, 2022

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Aug 27, 2022 •
edited
Loading

Motivation

Fix #1542

How to test the behavior?

from pynwb.file import LabMetaData
help(LabMetaData)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@oruebel oruebel requested a review from bendichter August 27, 2022 00:09
@oruebel oruebel mentioned this pull request Aug 27, 2022
Closed
3 tasks
bendichter
bendichter reviewed Aug 27, 2022
View reviewed changes
src/pynwb/file.py Outdated Show resolved Hide resolved
rly
rly previously approved these changes Sep 1, 2022
View reviewed changes
@rly
Copy link
Contributor

rly commented Sep 1, 2022

Please add a changelog and I think this is good to go.

@oruebel
Copy link
Contributor Author

oruebel commented Sep 1, 2022

Please add a changelog and I think this is good to go.

Done. This PR is ready. @rly can you please approve and merge.

@rly rly merged commit fc78e34 into dev Sep 1, 2022
@rly rly deleted the enh/labmetadatadocs branch September 1, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendichter bendichter bendichter left review comments

@rly rly rly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Documentation]: guidance on how to use LabMetaData
3 participants
@oruebel @rly @bendichter