S3fs

[bendichter]

Motivation

Relax args to enable s3fs

Requires hdmf-dev/hdmf#746

How to test the behavior?

import s3fs
import pynwb
import h5py

fs = s3fs.S3FileSystem(anon=True)

f = fs.open("s3://dandiarchive/blobs/43b/f3a/43bf3a81-4a0b-433f-b471-1f10303f9d35", 'rb')
file = h5py.File(f)
io = pynwb.NWBHDF5IO(file=file, load_namespaces=True)

io.read()

to do

• change log
• tutorial
• test

Checklist

• Did you update CHANGELOG.md with your changes?
• Have you checked our Contributing document?
• Have you ensured the PR clearly describes the problem and the solution?
• Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
• Have you checked to ensure that there aren't other open Pull Requests for the same change?
• Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

[codecov]

Codecov Report

Merging #1499 (c27a692) into dev (a61a3de) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1499      +/-   ##
==========================================
- Coverage   90.52%   90.52%   -0.01%     
==========================================
  Files          25       25              
  Lines        2460     2459       -1     
  Branches      456      456              
==========================================
- Hits         2227     2226       -1     
  Misses        148      148              
  Partials       85       85              

Flag	Coverage Δ
integration	69.86% <100.00%> (-0.02%)	⬇️
unit	83.93% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/pynwb/device.py	100.00% <ø> (ø)
src/pynwb/io/file.py	94.33% <ø> (ø)
src/pynwb/__init__.py	77.37% <100.00%> (ø)
src/pynwb/core.py	74.39% <100.00%> (ø)
src/pynwb/ecephys.py	96.36% <100.00%> (-0.04%)	⬇️
src/pynwb/epoch.py	88.46% <100.00%> (ø)
src/pynwb/file.py	87.93% <100.00%> (ø)
src/pynwb/icephys.py	91.96% <100.00%> (ø)
src/pynwb/image.py	87.37% <100.00%> (ø)
src/pynwb/io/base.py	85.05% <100.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

[bendichter]

@rly I wanted to check with you with this PR and the hdmf PR before moving forward with the docs, tests, and change log

[rly]

@rly I wanted to check with you with this PR and the hdmf PR before moving forward with the docs, tests, and change log

This approach looks good to me. Can you add a comment about Windows incompatibility?