Skip to content

Commit

Permalink
Merge branch 'dev' into fix/optical-series-optional-fields
Browse files Browse the repository at this point in the history
  • Loading branch information
bendichter authored Jan 28, 2025
2 parents cb17d08 + c0ba7e1 commit add7b31
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
- Deprecated `EventWaveform` neurodata type. @rly [#1940](https://github.com/NeurodataWithoutBorders/pynwb/pull/1940)
- Deprecated `ImageMaskSeries` neurodata type. @rly [#1941](https://github.com/NeurodataWithoutBorders/pynwb/pull/1941)
- Removed python 3.8 support, added python 3.13 support. @stephprince [#2007](https://github.com/NeurodataWithoutBorders/pynwb/pull/2007)
- `mock_ElectricalSeries`. Make number of electrodes between data and electrode region agree when explicitly passing data @h-mayorquin [#2019](https://github.com/NeurodataWithoutBorders/pynwb/pull/2019)

### Documentation and tutorial enhancements
- Updated `SpikeEventSeries`, `DecompositionSeries`, and `FilteredEphys` examples. @stephprince [#2012](https://github.com/NeurodataWithoutBorders/pynwb/pull/2012)
Expand Down
5 changes: 3 additions & 2 deletions src/pynwb/testing/mock/ecephys.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,16 @@ def mock_ElectricalSeries(

# Set a default rate if timestamps are not provided
rate = 30_000.0 if (timestamps is None and rate is None) else rate
n_electrodes = data.shape[1] if data is not None else 5

electrical_series = ElectricalSeries(
name=name or name_generator("ElectricalSeries"),
description=description,
data=data if data is not None else np.ones((10, 5)),
data=data if data is not None else np.ones((10, n_electrodes)),
rate=rate,
starting_time=starting_time,
timestamps=timestamps,
electrodes=electrodes or mock_electrodes(nwbfile=nwbfile),
electrodes=electrodes or mock_electrodes(nwbfile=nwbfile, n_electrodes=n_electrodes),
filtering=filtering,
conversion=conversion,
offset=offset,
Expand Down

0 comments on commit add7b31

Please sign in to comment.