Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure persistent workflow changes appear in section states #715

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

garrettmflynn
Copy link
Member

This PR ensures that the section states that are related to a new workflow are regenerated and saved properly.

Should fix issues seen in #709

@garrettmflynn garrettmflynn self-assigned this Apr 3, 2024
@CodyCBakerPhD
Copy link
Collaborator

@garrettmflynn Caught another one

On the testing pipeline, Suite2P

Go to Ophys metadata -> try to enter the optic channel popup -> I get this

JSONSchemaInput.js:1019 Uncaught (in promise) TypeError: this.form.base is not iterable
    at #render (JSONSchemaInput.js:1019:64)
    at JSONSchemaInput.render (JSONSchemaInput.js:646:35)
    at JSONSchemaInput.update (lit-element.ts:160:24)
    at JSONSchemaInput.performUpdate (reactive-element.ts:1329:14)
    at JSONSchemaInput.scheduleUpdate (reactive-element.ts:1261:17)
    at JSONSchemaInput.__enqueueUpdate (reactive-element.ts:1233:25)

image

Do you want to fix here or in a follow-up? Also any way to add a test or story page for this?

@garrettmflynn
Copy link
Member Author

garrettmflynn commented Apr 3, 2024

E2E tests were simply failing before this because the registered workflows weren't peristent. Though this is implemented in the multi-session tutorial tests.

@CodyCBakerPhD
Copy link
Collaborator

E2E tests were simply failing before this because the registered workflows weren't peristent. Though this is implemented in the multi-session tutorial tests.

I saw, but I'm also doing a thorough local end to end test in response to Ryan asking for a build for the user test this afternoon

So how do you want to handle the other thing I noticed

@garrettmflynn
Copy link
Member Author

garrettmflynn commented Apr 3, 2024

Gotcha. I'll bump that into a follow-up PR. As for testing those pop-up table forms, I'll see about adding a non-E2E test for it.

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge April 3, 2024 16:54
@CodyCBakerPhD CodyCBakerPhD merged commit 9e71e9d into main Apr 3, 2024
14 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the ensure-workflow-persistence branch April 3, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants