Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip DANDI upload to allow tests to pass with broken external services #627

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

garrettmflynn
Copy link
Member

Skip the DANDI upload part of the E2E tests to avoid failing when external dependencies (e.g. the DANDI server) has an issue.

@CodyCBakerPhD
Copy link
Collaborator

What I'm requesting is that we split the current testing action into two actions; one that runs only the live service tests like DANDI upload, and one that runs only the non-live service tests that we can control

These would show up as two separate CI runs on a PR, and yes the live one would continue to fail until DANDI fixes their end

@garrettmflynn
Copy link
Member Author

garrettmflynn commented Feb 27, 2024

Sure. Though since this DANDI upload test is at the very end of the E2E workflow and requires a complete pipeline to finish, would it be sufficient to simply duplicate the testing.yml + keep the DANDI_STAGING_API that was removed here?

We could cache a complete pipeline instead, though that'll take a bit longer.

@CodyCBakerPhD
Copy link
Collaborator

Though since this DANDI upload test is at the very end of the E2E workflow and requires a complete pipeline to finish,

I see

would it be sufficient to simply duplicate the testing.yml + keep the DANDI_STAGING_API that was removed here?

that would be fine

Yes, a fancier/more efficient approach would either be to cache the output and go direct to upload or use a couple lines of PyNWB to generate a minimal file and do standalone upload of that - but these aren't entirely necessary

@garrettmflynn
Copy link
Member Author

Alright added that extra testing file

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) February 27, 2024 17:53
@CodyCBakerPhD CodyCBakerPhD merged commit 30fec80 into main Feb 27, 2024
12 of 15 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the skip-dandi-in-GA branch February 27, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants