Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ElectricalSeries->electrodes dataset write and add tests #156

Merged
merged 4 commits into from
Feb 16, 2025

Conversation

stephprince
Copy link
Collaborator

The ElectricalSeries->electrodes dataset was being written incorrectly due to an incorrect data type. I updated the data type and added tests for write/read of this ElectricalSeries->electrodes dataset to avoid this issue in the future.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.98%. Comparing base (d234fa0) to head (5d0986e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   93.93%   93.98%   +0.04%     
==========================================
  Files          64       64              
  Lines        4915     4952      +37     
  Branches      272      273       +1     
==========================================
+ Hits         4617     4654      +37     
  Misses        288      288              
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephprince stephprince marked this pull request as ready for review February 15, 2025 00:42
@stephprince stephprince requested a review from oruebel February 15, 2025 00:42
@oruebel oruebel merged commit 40fe1dc into main Feb 16, 2025
10 checks passed
@oruebel oruebel deleted the add-electrodes-es-tests branch February 16, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants