Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance unit test coverage #148

Merged
merged 6 commits into from
Feb 5, 2025
Merged

Enhance unit test coverage #148

merged 6 commits into from
Feb 5, 2025

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Jan 24, 2025

Most of this PR was done with Cline. Add separate unit tests for select classes to enhance overall coverage. Add unit tests for:

  • HDF5Recording
  • Channel

@oruebel oruebel requested a review from stephprince January 24, 2025 21:06
@oruebel
Copy link
Contributor Author

oruebel commented Jan 24, 2025

@stephprince this is ready for review

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.91%. Comparing base (00a529c) to head (d5f4e5d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   93.20%   93.91%   +0.71%     
==========================================
  Files          62       64       +2     
  Lines        4328     4572     +244     
  Branches      268      268              
==========================================
+ Hits         4034     4294     +260     
+ Misses        284      268      -16     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/testChannel.cpp Outdated Show resolved Hide resolved
tests/testChannel.cpp Show resolved Hide resolved
Copy link
Collaborator

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks!

@oruebel oruebel merged commit 9818339 into main Feb 5, 2025
10 checks passed
@oruebel oruebel deleted the enh_unit_coverage branch February 5, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants