Remove colNames from DynamicTable.initialize

NeurodataWithoutBorders · Jan 31, 2025 · df9267d · df9267d
1 parent 394c693
commit df9267d
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 10 deletions.
diff --git a/src/nwb/file/ElectrodeTable.cpp b/src/nwb/file/ElectrodeTable.cpp
@@ -44,8 +44,7 @@ ElectrodeTable::~ElectrodeTable() {}
 void ElectrodeTable::initialize(const std::string& description)
 {
   // create group
-  DynamicTable::initialize(description,
-                           {});  // create column_names in finalize()
+  DynamicTable::initialize(description);
 
   m_electrodeDataset->initialize(std::unique_ptr<IO::BaseRecordingData>(
       m_io->createArrayDataSet(IO::BaseDataType::I32,

diff --git a/src/nwb/file/ElectrodeTable.hpp b/src/nwb/file/ElectrodeTable.hpp
@@ -66,9 +66,6 @@ class ElectrodeTable : public DynamicTable
       "/general/extracellular_ephys/electrodes";
 
 private:
-  const std::vector<std::string> m_defaultColNames = {
-      "group", "group_name", "location"};
-
   /**
    * @brief The global indices for each electrode.
    */

diff --git a/src/nwb/hdmf/table/DynamicTable.cpp b/src/nwb/hdmf/table/DynamicTable.cpp
@@ -20,11 +20,9 @@ DynamicTable::DynamicTable(const std::string& path,
 DynamicTable::~DynamicTable() {}
 
 /** Initialization function*/
-void DynamicTable::initialize(const std::string& description,
-                              const std::vector<std::string>& colNames)
+void DynamicTable::initialize(const std::string& description)
 {
   Container::initialize();
-  m_colNames = colNames;
   if (description != "")
     m_io->createAttribute(description, m_path, "description");
 }

diff --git a/src/nwb/hdmf/table/DynamicTable.hpp b/src/nwb/hdmf/table/DynamicTable.hpp
@@ -43,8 +43,7 @@ class DynamicTable : public Container
    * @param description The description of the table (optional).
    * @param colNames Names of the columns for the table
    */
-  void initialize(const std::string& description,
-                  const std::vector<std::string>& colNames);
+  void initialize(const std::string& description);
 
   /**
    * @brief Adds a column of vector string data to the table.