-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix powerspectrum bands on notebooks #527
Conversation
The CI Basics errors have to do with this line Neuroblox.jl/src/Neurographs.jl Line 184 in 69b1022
where Neuroblox.jl/src/Neurographs.jl Lines 84 to 102 in 69b1022
I don't see how this is affected by this PR. I tried updating my local environment in case it was an upstream issue but the same tests pass for me. |
Ok as suspected Neuroblox.jl/src/Neurographs.jl Line 94 in 69b1022
gave the same number twice. Passes after rerunning. We could write so that it's impossible to hit duplicates but this is a quick (lazy) fix for now. |
Great, all test passed! Should we merge it already? |
This PR fixes the repeated generation of powerspectrum bands and labels in Jupyter notebooks and Literate caused by those notebooks making Makie compute the final limits twice. With this change, the bands and labels are created only the first time, and the following times only their bounds/positions are modified.
I also reduced the threshold for checking if the solution was saved at regular time steps to avoid spurious warnings.