Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Add external calls validation #916

Merged
merged 5 commits into from
Feb 16, 2023
Merged

Add external calls validation #916

merged 5 commits into from
Feb 16, 2023

Conversation

piwonskp
Copy link
Contributor

Fixes #904

@rjnrohit
Copy link
Contributor

rjnrohit commented Feb 14, 2023

can you add a behaviour test where this check should throw an error?

if (expectedResult === null) {
expect(response.threw, `${name} - Function should throw`).to.be.true;
error_message !== undefined &&
response.error_message !== undefined &&
expect(response.error_message).to.include(error_message);

@piwonskp piwonskp merged commit dc5a623 into develop Feb 16, 2023
@piwonskp piwonskp deleted the validate-external-calls branch February 16, 2023 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

CRITICAL: Contract-to-contract calling must check bounds of return variables
4 participants