Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Include note about lido-status flags #490

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Conversation

khalifaa55
Copy link
Contributor

Changes:

  • Include note about lido-status flags (rewardsAddress and nodeID) in command help docs.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@khalifaa55 khalifaa55 self-assigned this Jan 9, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.75%. Comparing base (299ba6f) to head (cd5a539).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #490   +/-   ##
========================================
  Coverage    24.75%   24.75%           
========================================
  Files          120      120           
  Lines        22305    22305           
========================================
  Hits          5521     5521           
  Misses       16239    16239           
  Partials       545      545           
Flag Coverage Δ
unittests 24.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khalifaa55 khalifaa55 merged commit 07b369e into develop Jan 20, 2025
11 checks passed
@khalifaa55 khalifaa55 deleted the docs/lido-flags branch January 20, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants