Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mev container display on holesky, even if not supported #322

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

stdevMac
Copy link
Member

Changes:

  • Mev container display on holesky, even if not supported

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

@stdevMac stdevMac requested a review from AntiD2ta October 16, 2023 20:29
@stdevMac stdevMac self-assigned this Oct 16, 2023
Copy link
Member

@AntiD2ta AntiD2ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no regression tests for this. There should be test cases for holesky that check there is no mev-boost config generated

@stdevMac
Copy link
Member Author

There is no regression tests for this. There should be test cases for holesky that check there is no mev-boost config generated

Added test for that functionality at here 68a93fe

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (07606de) 86.13% compared to head (68a93fe) 86.13%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #322   +/-   ##
========================================
  Coverage    86.13%   86.13%           
========================================
  Files           78       78           
  Lines         4558     4558           
========================================
  Hits          3926     3926           
  Misses         547      547           
  Partials        85       85           
Flag Coverage Δ
unittests 86.13% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/pkg/generate/generate_scripts.go 89.38% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AntiD2ta AntiD2ta merged commit b684e94 into develop Oct 18, 2023
@AntiD2ta AntiD2ta deleted the fix/mev-holesky branch October 18, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants