Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for latest version #316

Merged
merged 17 commits into from
Oct 13, 2023
Merged

Add flag for latest version #316

merged 17 commits into from
Oct 13, 2023

Conversation

stdevMac
Copy link
Member

@stdevMac stdevMac commented Oct 3, 2023

Changes:

  • Add a flag --latest to generate subcommands (full-node, execution, consensus and validator) to set latest as the image tag for client images.

Types of changes

  • New feature (non-breaking change which adds functionality)

Testing

Requires testing

  • Yes

In case you checked yes, did you write tests?

  • Yes

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (23bcdfe) 86.74% compared to head (f3a9b35) 86.76%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #316      +/-   ##
===========================================
+ Coverage    86.74%   86.76%   +0.02%     
===========================================
  Files           78       78              
  Lines         4548     4557       +9     
===========================================
+ Hits          3945     3954       +9     
  Misses         518      518              
  Partials        85       85              
Flag Coverage Δ
unittests 86.76% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cli/generate.go 90.41% <100.00%> (+0.03%) ⬆️
cli/sub_gen.go 93.80% <100.00%> (+0.12%) ⬆️
internal/pkg/generate/generate_scripts.go 96.55% <100.00%> (+0.03%) ⬆️
internal/pkg/generate/types.go 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stdevMac stdevMac merged commit 2d20170 into develop Oct 13, 2023
@stdevMac stdevMac deleted the feat/latest-flag branch October 13, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants