Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-1108 implementation #814 #819

Merged
merged 3 commits into from
Aug 23, 2019
Merged

EIP-1108 implementation #814 #819

merged 3 commits into from
Aug 23, 2019

Conversation

tkstanczak
Copy link
Member

No description provided.

@tkstanczak tkstanczak requested a review from spetz August 23, 2019 08:29
spetz
spetz previously approved these changes Aug 23, 2019
@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #819 into master will increase coverage by 4.87%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #819      +/-   ##
==========================================
+ Coverage   31.97%   36.85%   +4.87%     
==========================================
  Files         583      598      +15     
  Lines       33287    34263     +976     
==========================================
+ Hits        10644    12627    +1983     
+ Misses      22643    21636    -1007
Impacted Files Coverage Δ
...nd.Evm/Precompiles/ECRecoverPrecompiledContract.cs 16.66% <ø> (ø) ⬆️
...rmind.Evm/Precompiles/ModExpPrecompiledContract.cs 9.43% <ø> (ø) ⬆️
...nd.Evm/Precompiles/Ripemd160PrecompiledContract.cs 33.33% <ø> (ø) ⬆️
...ind.Evm/Precompiles/IdentityPrecompiledContract.cs 100% <ø> (ø) ⬆️
...rmind.Evm/Precompiles/Sha256PrecompiledContract.cs 41.17% <ø> (ø) ⬆️
...Evm/Precompiles/Bn128PairingPrecompiledContract.cs 76.36% <100%> (+67.27%) ⬆️
src/Nethermind/Nethermind.Core/Address.cs 87.73% <100%> (+3.12%) ⬆️
...ind.Evm/Precompiles/Bn128MulPrecompiledContract.cs 78.37% <100%> (+64.86%) ⬆️
...ind.Evm/Precompiles/Bn128AddPrecompiledContract.cs 76.19% <100%> (+64.28%) ⬆️
src/Nethermind/Nethermind.Evm/VirtualMachine.cs 61.49% <100%> (ø) ⬆️
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ec55d5...e36207c. Read the comment docs.

@tkstanczak tkstanczak merged commit 9ad4e5c into master Aug 23, 2019
@tkstanczak tkstanczak deleted the eip1108-814 branch August 29, 2019 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants