Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: function attributes #34

Merged
merged 3 commits into from
Jun 20, 2023
Merged

feat: function attributes #34

merged 3 commits into from
Jun 20, 2023

Conversation

julio4
Copy link
Member

@julio4 julio4 commented Jun 20, 2023

Close #5

@enitrat
Copy link
Collaborator

enitrat commented Jun 20, 2023

@julio4 CI fails

@julio4
Copy link
Member Author

julio4 commented Jun 20, 2023

@julio4 CI fails

Fixed ✅

julio4
julio4 commented Jun 20, 2023
View reviewed changes
scripts/cairo_programs_verifier.sh
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chmod u+x

enitrat
enitrat approved these changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful 🤝

@enitrat enitrat merged commit f4b6ebb into NethermindEth:main Jun 20, 2023
@julio4 julio4 deleted the feat/function_attributes branch June 20, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enitrat enitrat enitrat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: internal, view and external functions
2 participants
@julio4 @enitrat