Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update outdated links to external resources #156

Merged
merged 3 commits into from
Dec 17, 2023
Merged

fix: update outdated links to external resources #156

merged 3 commits into from
Dec 17, 2023

Conversation

krauspt
Copy link
Contributor

@krauspt krauspt commented Dec 16, 2023

Description

Hello,
I'm replacing two outdated links to external resources with working versions. One of them is to Starknet docs and the second to Cairo lang book.

Didn't do anything from checklist below, as the changes are only in documentation.

Checklist

  • CI Verifier: Run cairo_programs_verifier successfully
  • Contract Tests: Added tests to cover the changes
  • Remix Link: Added a link to open the contract in Remix
  • Deployed Contract (Optional): If possible, include a Voyager link to a deployed contract on Goerli

julio4
julio4 approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@julio4 julio4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@julio4 julio4 merged commit 0209123 into NethermindEth:main Dec 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julio4 julio4 julio4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krauspt @julio4