Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TLS-ALPN-01 challenge #81

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Use TLS-ALPN-01 challenge #81

merged 3 commits into from
Feb 19, 2025

Conversation

DavidePrincipi
Copy link
Member

@DavidePrincipi DavidePrincipi commented Feb 18, 2025 •
edited
Loading

This pull request

  • fixes a configuration conflict with set-trusted-proxies configuration, by avoiding the complete rewrite of traefik.yaml.
  • starts to use TLS-ALPN-01 challenge on new installations. Existing installations will continue to use HTTP-01.
  • adds new parameters to set-acme-server to set email and challenge type.

Refs NethServer/dev#7305

@DavidePrincipi
fix: conflicts with set-trusted-proxies
e60e96c 
Do not completely rewrite traefik.yaml, instead change its contents
punctually. This new behavior preserves also manual customizations.

Add new email and challenge type attributes (optional).
@DavidePrincipi
feat(doc): new set-acme-server parameters
a3a0d09
@DavidePrincipi
feat!: default challenge TLS-ALPN-01
fddda2a 
For new installations, use the HTTPS-based challenge protocol.
gsanchietti
gsanchietti approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, but really hard to review it without testing it.

@DavidePrincipi DavidePrincipi merged commit 7de5b7f into main Feb 19, 2025
5 checks passed
@DavidePrincipi DavidePrincipi deleted the feat-7305-2 branch February 19, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amygos Amygos Amygos approved these changes

@gsanchietti gsanchietti gsanchietti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidePrincipi @Amygos @gsanchietti