Wrong migration of Mail's "Accept Unknown Recipients" setting

[stephdl]

The bug occurs when we have set in NS7 domain the "Accept unknown recipients" flag

Steps to reproduce

• install a mail server with an AD
• create a simple user foo, in a group with a true password (user enabled)
• in the domain of the mail server, set the flag true "Accept unknown recipients" and deliver the anonymous email to foo
• install nethserver-ns8-migration
• migrate the stack to a NS8

Expected behavior

I expect a migration without issue

Actual behavior

The migration goes well, no warnings or errors but when you go to the domain of the mail server in NS8, the page is no longer browseable, you have an error displayed

Validation errors: [0.catchall: Must validate one and only one schema (oneOf) 0.catchall.dtype: 0.catchall.dtype must be one of the following: "user", "group", "public", "apo"]

this is what the api output

[root@R1-pve ~]# api-cli run module/mail2/list-domains | jq
Warning: using user "cluster" credentials from the environment
Validation errors: [0.catchall: Must validate one and only one schema (oneOf) 0.catchall.dtype: 0.catchall.dtype must be one of the following: "user", "group", "public", "apo"]
[
  {
    "domain": "ns7-pve2.org",
    "addusers": true,
    "addgroups": false,
    "catchall": {
      "dtype": "external",
      "name": "[email protected]"
    },
    "bccaddr": null,
    "description": ""
  }
]

If I set to null the catchall option, I can display the form and set a catchall from the ns8 UI

[root@R1-pve ~]# api-cli run module/mail2/alter-domain --data '{"domain":"ns7-pve2.org","catchall":null}'
Warning: using user "cluster" credentials from the environment
{"domain": "ns7-pve2.org", "addusers": true, "addgroups": false, "catchall": null, "bccaddr": null, "description": ""}
[root@R1-pve ~]# api-cli run module/mail2/list-domains | jq
Warning: using user "cluster" credentials from the environment
[
  {
    "domain": "ns7-pve2.org",
    "addusers": false,
    "addgroups": false,
    "catchall": {
      "dtype": "user",
      "name": "stephane",
      "ui_name": "stephane de labrusse"
    },
    "bccaddr": null,
    "description": ""
  }
]

However we can see that we have probably an incompatible option between NS7 and NS8 because the option add user from user domain is not allowed with accept unknown recipient

if we look to the domains.json that we have migrated to NS8, we find

[mail2@R1-pve state]$ cat domains.json 
[{"props":{"UnknownRecipientsActionDeliverMailbox":"[email protected]","TransportType":"LocalDelivery","AlwaysBccStatus":"disabled","DisclaimerStatus":"disabled","RelayHost":"","AlwaysBccAddress":"","Description":"","UnknownRecipientsActionType":"deliver"},"name":"ns7-pve2.org","type":"domain"}][mail2@R1-pve state]$ 

Components

nethserver-ns8-migration-1.1.0-1

See also

• https://community.nethserver.org/t/mail-domain-list-fails-after-migration-from-nethserver-7/25207
• https://mattermost.nethesis.it/nethesis/pl/z1oznoheyp8bfj9xpotst7wg6r

--

thank Mark Albrecht

[stephdl]

QA

prepare a NS7 mail server with the option Accept unknown recipients enabled
install nethserver-ns8-migration
modify the file /usr/share/nethesis/nethserver-ns8-migration/apps/nethserver-mail/bind.env to point to the goo ns8-mail version ghcr.io/nethserver/mail:1.5.2-dev.1
migrate the NS7 mail server to NS8
once migrated you can open the domain page of the mail server in NS8, the bug is no more reproducible

[lucagasparini]

VERIFIED
I confirm that the bug is not reproducible 👍

[stephdl]

released https://github.com/NethServer/ns8-mail/releases/tag/1.5.2