Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change name of swap:full alarm #7163

Closed
DavidePrincipi opened this issue Nov 20, 2024 · 3 comments
Closed

Change name of swap:full alarm #7163

DavidePrincipi opened this issue Nov 20, 2024 · 3 comments
Assignees
@gsanchietti @nrauso
Labels
verified All test cases were verified successfully
Milestone
NethServer 8.4

Comments

@DavidePrincipi
Copy link
Member

DavidePrincipi commented Nov 20, 2024 •
edited
Loading

The alarm name swap:full is triggered also if no swap space is configured on the leader node. This can be misleading because no swap (config issue) is different than swap full (performance issue).

Discussion
@DavidePrincipi DavidePrincipi converted this from a draft issue Nov 20, 2024
@gsanchietti gsanchietti self-assigned this Feb 17, 2025
@gsanchietti gsanchietti moved this from Backlog to In Progress in NethServer Feb 17, 2025
@gsanchietti gsanchietti added this to the NethServer 8.4 milestone Feb 17, 2025
@gsanchietti gsanchietti mentioned this issue Feb 17, 2025
Merged
gsanchietti added a commit to NethServer/ns8-core that referenced this issue Feb 18, 2025
@gsanchietti
fix(node-monitor): add new swap alert (#812)
48add74 
Changes:

- do not raise swap:full:<node_id> alert if the swap is not configured
- add a new swap:notpresent:<node_id> alert if swap is not present

NethServer/dev#7163
@gsanchietti
Copy link
Member

In testing: core-3.4.6-dev.1

Test case 1

  • Create a machine without swap
  • Verify that the swap:full:<node_id> alert is not raised

Test case 2

  • Verify that the swap:notpresent:<node_id> alert is raised
  • Add a swap: 
    dd if=/dev/zero of=/swap bs=1M count=100
mkswap /swap
swapon /swap
  • Wait 30 minutes, verify the alert swap:notpresent:<node_id> is resolved

@gsanchietti gsanchietti moved this from In Progress to Testing in NethServer Feb 18, 2025
@gsanchietti gsanchietti added the testing Packages are available from testing repositories label Feb 18, 2025
@nrauso nrauso self-assigned this Feb 18, 2025
@nrauso
Copy link

nrauso commented Feb 18, 2025

test case 1: VERIFIED
test case 2: VERIFIED

This is the status on the NOC portal a few minutes after installation (without SWAP):

Image

and this is the status on the NOC portal a few minutes after creating the SWAP:

Image

@nrauso nrauso added the verified All test cases were verified successfully label Feb 18, 2025
@github-actions github-actions bot removed the testing Packages are available from testing repositories label Feb 18, 2025
@nethbot nethbot moved this from Testing to Verified in NethServer Feb 18, 2025
@DavidePrincipi
Copy link
Member Author

Released https://github.com/NethServer/ns8-core/releases/tag/3.4.6

@github-project-automation github-project-automation bot moved this from Verified to Done in NethServer Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsanchietti gsanchietti

@nrauso nrauso

Labels
verified All test cases were verified successfully
Projects
NethServer
Status: Done
Milestone
NethServer 8.4
Development

No branches or pull requests
3 participants
@gsanchietti @DavidePrincipi @nrauso