Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom and requested certificates are listed twice #6987

Open
Amygos opened this issue Aug 1, 2024 · 1 comment
Open

Custom and requested certificates are listed twice #6987

Amygos opened this issue Aug 1, 2024 · 1 comment
Assignees

Comments

@Amygos
Copy link
Member

Amygos commented Aug 1, 2024

Steps to reproduce

  • Upload a custom certificate
  • Request a certificate for the same domain
  • Get the list of the current certificates

Expected behavior

Only the custom certificate is listed, the custom one has precedence over the requested ones.

Actual behavior

The certificate is listed twice, eg.:

[root@nethserver ~]# api-cli run module/traefik1/list-certificates -d '{"expand_list":true}' | jq
Warning: using user "cluster" credentials from the environment
[
  {
    "fqdn": "test.example.com",
    "type": "internal",
    "obtained": false
  },
  {
    "fqdn": "test.example.com",
    "type": "custom",
    "obtained": true
  }
]

Components

https://github.com/NethServer/ns8-traefik

See also

@Amygos Amygos added the bug label Aug 1, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in NethServer Aug 1, 2024
@Amygos Amygos changed the title traefik: custom certificates and requested certificate are listed twice traefik: custom certificates and requested certificates are listed twice Aug 1, 2024
@Amygos Amygos self-assigned this Aug 1, 2024
@DavidePrincipi DavidePrincipi moved this from New to Backlog in NethServer Sep 16, 2024
@DavidePrincipi DavidePrincipi moved this from Backlog to In progress in NethServer Sep 16, 2024
@DavidePrincipi DavidePrincipi moved this from In progress to Ready in NethServer Sep 19, 2024
@DavidePrincipi DavidePrincipi changed the title traefik: custom certificates and requested certificates are listed twice Custom certificates and requested certificates are listed twice Oct 24, 2024
@DavidePrincipi DavidePrincipi changed the title Custom certificates and requested certificates are listed twice Custom and requested certificates are listed twice Oct 24, 2024
@DavidePrincipi DavidePrincipi added this to the NethServer M8.3 milestone Nov 7, 2024
@gsanchietti gsanchietti removed the bug label Nov 14, 2024
@DavidePrincipi DavidePrincipi self-assigned this Jan 21, 2025
@DavidePrincipi DavidePrincipi moved this from ToDo to In Progress in NethServer Jan 21, 2025
@DavidePrincipi
Copy link
Member

DavidePrincipi commented Feb 17, 2025

Fix plans, discussed with @Amygos :

  • Keep list-certificates unchanged
  • Change delete-certificate to require an additional parameter to identify which certificate must be deleted: internal or custom? fix!: avoid temporary Traefik cert ns8-traefik#84
  • Change get-certificate to return an array of certificates matching the requested fqdn, ordered by priority

DavidePrincipi added a commit to NethServer/ns8-traefik that referenced this issue Feb 27, 2025
Check if the names of defaultGeneratedCert are already present in
acme.json to ensure the certificate can be successfully obtained.

Refs NethServer/dev#6987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

3 participants