Add metadata to ConsoleMe cred request body #48
Conversation
| "github.com/netflix/weep/util" | ||
| ) | ||
|
|
||
| func IamInfoHandler(w http.ResponseWriter, r *http.Request) { | ||
|
|
||
| awsArn, _ := util.ArnParse(metadata.Role) | ||
| // TODO: this was crashing because of a nil pointer dereference. Fix it! |
There was a problem hiding this comment.
Not sure if you meant to commit with this TODO.
Is it nil because a role may not be specified for the new combined metadata and ECS mode? would a simple check to check metadata.Role first suffice?
There was a problem hiding this comment.
This is a TODO for later, along with the others. The old metadata package had almost everything refactored out of it other than a few variables that were directly accessed, which was an anti-pattern. I'll be able to fix it with the CLI UX refactor since we'll be able to count on a "default" role being set.
Also, the endpoint that this handler is for doesn't get called frequently (or maybe at all) -- if it was, it would panic with a nil pointer dereference. There's a decent chance we could just remove it entirely.
| iamInfo := MetaDataIamInfoResponse{ | ||
| Code: "Success", | ||
| //LastUpdated: metadata.LastRenewal.UTC().Format("2006-01-02T15:04:05Z"), | ||
| LastUpdated: "", // TODO: fix this |
There was a problem hiding this comment.
Ditto for this TODO. If we don't have metadata.LastRenewal, make it blank?
|
|
||
| awsArn, err := util.ArnParse(metadata.Role) | ||
| // TODO: this was crashing because of a nil pointer dereference. Fix it! | ||
| awsArn, err := util.ArnParse("") |
There was a problem hiding this comment.
Maybe we should bail on serving metadata if metadata.Role is not defined, and just serve a generic error?
This PR adds some system metadata in ConsoleMe credential requests to be used as session tags when generating credentials. There's also a bit of refactoring to pay down some tech debt.