refactor: remove feature name from VmafMetadataConfiguration

Netflix · Feb 2, 2025 · a696d7c · a696d7c
1 parent 1246b72
commit a696d7c
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 10 deletions.
diff --git a/libvmaf/include/libvmaf/libvmaf.h b/libvmaf/include/libvmaf/libvmaf.h
@@ -280,7 +280,6 @@ typedef struct VmafMetadata {
  * @param data         User data to pass to the callback.
  */
 typedef struct VmafMetadataConfiguration {
-    char *feature_name;
     void (*callback)(void *data, VmafMetadata *metadata);
     void *data;
 } VmafMetadataConfiguration;

diff --git a/libvmaf/src/feature/feature_collector.c b/libvmaf/src/feature/feature_collector.c
@@ -291,7 +291,6 @@ int vmaf_feature_collector_register_metadata(VmafFeatureCollector *feature_colle
                                              VmafMetadataConfiguration metadata_cfg)
 {
     if (!feature_collector) return -EINVAL;
-    if (!metadata_cfg.feature_name) return -EINVAL;
     if (!metadata_cfg.callback) return -EINVAL;
 
     VmafCallbackList *metadata = feature_collector->metadata;

diff --git a/libvmaf/test/test_propagate_metadata.c b/libvmaf/test/test_propagate_metadata.c
@@ -128,7 +128,6 @@ static char* test_propagate_metadata()
     };
 
     VmafMetadataConfiguration m = {
-        .feature_name = "vmaf",
         .callback = set_meta,
         .data     = &meta_data,
     };
@@ -167,7 +166,6 @@ static char* test_propagate_metadata()
     vmaf_feature_collector_destroy(feature_collector);
 
     m.data = NULL;
-    m.feature_name = "vmaf";
     err = vmaf_feature_collector_init(&feature_collector);
     mu_assert("problem during vmaf_feature_collector_init", !err);
 
@@ -183,7 +181,6 @@ static char* test_propagate_metadata()
     vmaf_feature_collector_destroy(feature_collector);
 
     m.callback = NULL;
-    m.feature_name = "vmaf";
     err = vmaf_feature_collector_init(&feature_collector);
     mu_assert("problem during vmaf_feature_collector_init", !err);
 
@@ -213,7 +210,6 @@ static char *test_propagate_metadata_non_monotonic()
     };
 
     VmafMetadataConfiguration m = {
-        .feature_name = strdup("vmaf"),
         .callback = test_non_monotonic_callback,
         .data = &meta_data,
     };
@@ -318,13 +314,11 @@ static char *test_multiple_callbacks()
     };
 
     VmafMetadataConfiguration m1 = {
-        .feature_name = "vmaf",
         .callback = multi_callback,
         .data = &cb_data1,
     };
 
     VmafMetadataConfiguration m2 = {
-        .feature_name = "vmaf",
         .callback = multi_callback,
         .data = &cb_data2,
     };
@@ -397,13 +391,11 @@ static char *test_multiple_callbacks_non_monotonic()
     };
 
     VmafMetadataConfiguration m1 = {
-        .feature_name = "vmaf",
         .callback = multi_callback,
         .data = &cb_data1,
     };
 
     VmafMetadataConfiguration m2 = {
-        .feature_name = "vmaf",
         .callback = multi_callback,
         .data = &cb_data2,
     };