This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Start refactoring the executor to further split up Docker and runtime… #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sargun
force-pushed
the
multi-executor
branch
2 times, most recently
from
b24c4d5 to
3b2fba8
Compare
fabiokung
approved these changes
Feb 6, 2018
There was a problem hiding this comment.
LGTM, though I'm not 100% sure why moving things from runtime to runtime/types will help. Maybe that will become clearer with future patches? Will it help prevent some circular dependency?
Right now it's in an odd state where runtime is mostly empty and could probably go away (be entirely empty thus not a Go package), and there's no visible difference in having things inside types vs inside runtime.
|
There was common code between the independent executor path, and runtime. As I'm refactoring, I'm trying to separate out the common code vs. code that has the shared state in it. |
sargun
force-pushed
the
multi-executor
branch
from
3b2fba8 to
3e686ff
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should have no functional / logical changes. It's just rearranging code so runtime/executor.go can be factored out into common (stateless, and stateful) code to be shared between one-shot container run, and long-running code.