This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Fail on no entrypoint, don't crash #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sargun
force-pushed
the
fail-on-no-entrypoint
branch
from
6bf5010 to
93e2a88
Compare
fabiokung
suggested changes
Nov 13, 2017
executor/runtime/docker.go
Outdated
| log.Errorf("Error in inspecting docker image %s : %v\n", image, err) | ||
| return 0 | ||
| } | ||
| func (r *DockerRuntime) reportDockerImageSizeMetric(c *Container, imageInfo types.ImageInspect, image string) int64 { |
There was a problem hiding this comment.
remove unused image argument
executor/runtime/docker.go
Outdated
| return true | ||
| } | ||
|
|
||
| if imageInfo.Config.Entrypoint != nil || imageInfo.Config.Cmd != nil { |
There was a problem hiding this comment.
refactor this if-else chain into return imageInfo.Config.Entrypoint != nil || imageInfo.Config.Cmd != nil
fabiokung
approved these changes
Nov 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.