This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Terminate during prepare #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
+ Coverage 35.55% 35.69% +0.13%
==========================================
Files 65 65
Lines 7341 7349 +8
==========================================
+ Hits 2610 2623 +13
+ Misses 4430 4425 -5
Partials 301 301
|
sargun
force-pushed
the
terminate-during-prepare
branch
2 times, most recently
from
8cd092e to
8d75def
Compare
Pull Request Test Coverage Report for Build 907
💛 - Coveralls |
|
The code is still very much scratch now, but what do you think -- if we get a kill, should we cancel the prepare context (and therefore the image download)? |
sargun
force-pushed
the
terminate-during-prepare
branch
from
6b23ba9 to
e7e59af
Compare
|
@fabiokung @andrew-leung This should be ready to look at. |
fabiokung
approved these changes
May 15, 2018
| @@ -260,10 +260,19 @@ no_launchguard: | |||
| } | |||
| r.updateStatus(ctx, titusdriver.Starting, "creating") | |||
|
|
|||
| prepareCtx, prepareCancel := context.WithCancel(ctx) | |||
| defer prepareCancel() | |||
There was a problem hiding this comment.
minor: I think this can be moved to a single prepareCancel call right after Prepare(...) (and right before the if err != nil), since it's the only place it needs to be called, regardless if Prepare failed or not.
There was a problem hiding this comment.
metalinter complains if I do this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.