This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Remove tmpfs at /run #105
Merged
Remove tmpfs at /run #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 557
💛 - Coveralls |
andrew-leung
approved these changes
May 8, 2018
Automatically mounting a tmpfs at /run causes all sorts of interesting issues with copying stuff into the container. In addition, there are some images (like Ubuntu, that place stuff under /run), an example: /run /run/utmp /run/mount /run/mount/utab /run/lock /run/systemd /run/systemd/was-enabled /run/systemd/container -- When we try to cp anything into the container under /run, it gets confused as well, and it tries to copy to the layer provided by the graphdriver rather than the actual container filesystem.
fabiokung
approved these changes
May 8, 2018
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 35.08% 34.99% -0.09%
==========================================
Files 65 65
Lines 7316 7306 -10
==========================================
- Hits 2567 2557 -10
Misses 4439 4439
Partials 310 310
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically mounting a tmpfs at /run causes
all sorts of interesting issues with copying stuff into the container.