go-expect test compatibility on windows #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @prietyc123, thanks for this PR. Can you get the travis job for windows working? |
So this pr will basically executes the tests on windows successfully where go-expect package is used. It replaces https://github.com/kr/pty with https://github.com/creack/pty.
I will try to make it work for windows. Can I do it in separate pr once it get merged? |
|
Since this PR's goal is to execute tests on windows successfully, I would like it working on travis (for windows) in the same PR. |
prietyc123
force-pushed
the
GoexpectSupportOnWindows
branch
from
2637b4d to
c1b9a23
Compare
|
Any news on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes go-expect test compatibility on windows by replacing https://github.com/kr/pty with https://github.com/creack/pty and adding some dependencies.
Fixes #10