Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HystrixObservableCollapser does not properly handle streams per request arg #865

Closed
mattrjacobs opened this issue Aug 19, 2015 · 1 comment
Closed

HystrixObservableCollapser does not properly handle streams per request arg #865

mattrjacobs opened this issue Aug 19, 2015 · 1 comment
Labels
bug hystrix-core

Comments

@mattrjacobs
Copy link
Contributor

Bug reported in https://groups.google.com/forum/#!topic/hystrixoss/etlb_JE90CU.

The root cause is that, upon receiving the first piece of a batch response which matches a request arg, that Collapser has onNext(data) and onCompleted() invoked. This happens even if more data is available for that Collapser.
mattrjacobs pushed a commit to mattrjacobs/Hystrix that referenced this issue Sep 1, 2015
Allowing Collapsers to return multiple values per request argument. A…
d681b3d 
…ddresses Netflix#865
@mattrjacobs mattrjacobs mentioned this issue Sep 1, 2015
Closed
mattrjacobs pushed a commit to mattrjacobs/Hystrix that referenced this issue Sep 9, 2015
Allowing Collapsers to return multiple values per request argument. A…
9726e5e 
…ddresses Netflix#865
mattrjacobs pushed a commit to mattrjacobs/Hystrix that referenced this issue Sep 10, 2015
Allowing Collapsers to return multiple values per request argument. A…
26fd11d 
…ddresses Netflix#865
@mattrjacobs mattrjacobs mentioned this issue Sep 10, 2015
Merged
@mattrjacobs
Copy link
Contributor Author

Released in 1.4.15 and merged into master to appear in first 1.5.0.rc1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug hystrix-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattrjacobs