Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPDEV-101357] Remove PSP and master role support #665

Merged
merged 4 commits into from
May 29, 2024

Conversation

ilia1243
Copy link
Contributor

@ilia1243 ilia1243 commented May 27, 2024

Description

  • Remove Kubernetes v1.23, v1.24 and all related code.
  • Remove PSP support and all related code.
  • No longer support master role.
    • Support of this role was preserved for do procedure.

Fixes #55

Breaking changes

  • master is not supported neither in nodes.roles nor in other sections that refer to roles, e.g thirdparties.group.
  • Checks of master role existence in jinja templates will no longer work, e. g. {{ nodes | select("has_role", "master") | list }}

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

Unit tests

test_do.py - cover support of master role for do procedure.

@ilia1243 ilia1243 added documentation Improvements or additions to documentation feature labels May 27, 2024
@ilia1243 ilia1243 requested review from Imadzuma and alexarefev May 27, 2024 15:49
@ilia1243 ilia1243 changed the title [CPDEV-101357] Rremove PSP support [CPDEV-101357] Remove PSP support May 27, 2024
@ilia1243 ilia1243 force-pushed the deprecation/remove_psp_support branch from 88c19a8 to ac5bc5d Compare May 27, 2024 17:17
@ilia1243 ilia1243 requested a review from disa1217 May 27, 2024 17:17
@ilia1243 ilia1243 changed the title [CPDEV-101357] Remove PSP support [CPDEV-101357] Remove PSP and master role support May 27, 2024
@koryaga koryaga requested a review from n549 May 28, 2024 05:42
@ilia1243 ilia1243 force-pushed the deprecation/remove_psp_support branch from ac5bc5d to ea5aa5c Compare May 28, 2024 08:08
Copy link
Contributor

@n549 n549 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably it's worth to remove Service Account Issuer description from IN? This FeatureGate was removed in v1.23.

@ilia1243
Copy link
Contributor Author

Probably it's worth to remove Service Account Issuer description from IN? This FeatureGate was removed in v1.23.

Only remove the feature-gates: "ServiceAccountIssuerDiscovery=true" or the whole description? As far as I see, related flags are still available https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/.

@n549
Copy link
Contributor

n549 commented May 28, 2024

Only remove the feature-gates: "ServiceAccountIssuerDiscovery=true" or the whole description? As far as I see, related flags are still available https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/.

yes, remove the feature-gates: "ServiceAccountIssuerDiscovery=true". And Service Account Issuer feature is supported only on Kubernetes 1.20. warning is not needed any more.

@ilia1243
Copy link
Contributor Author

Only remove the feature-gates: "ServiceAccountIssuerDiscovery=true" or the whole description? As far as I see, related flags are still available https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/.

yes, remove the feature-gates: "ServiceAccountIssuerDiscovery=true". And Service Account Issuer feature is supported only on Kubernetes 1.20. warning is not needed any more.

It is necessary to repeat the steps and make sure it is still working. Also there are few other guides that require actualization. Created issue #666

@ilia1243 ilia1243 force-pushed the deprecation/remove_psp_support branch from ea5aa5c to 8ec0c19 Compare May 29, 2024 10:49
@koryaga koryaga merged commit 2a47a72 into main May 29, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated label for nodes
5 participants