Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPDEV-100414] Install and check thirdparties skipping SSL verification #636

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

ilia1243
Copy link
Contributor

@ilia1243 ilia1243 commented Apr 10, 2024

Description

  • Install and check thirdparties skipping SSL verification.

Solution

  • Added curl -k option during install.
  • Disable SSL verification in check_url_availability.py using custom SSL context in HTTPSHandler.
  • software.thirdparties.availability check now respects probably not yet installed resolv.conf.

Test Cases

TestCase 1

Test Configuration:

  • OS: Ubuntu 22.04 / Centos 7
  • Inventory: services.thirdparties.source with self-signed certificate.

Steps:

  1. Install the cluster.

Results:

Before After
Installation fails Installation succeeds

TestCase 2

Test Configuration:

  • OS: Ubuntu 22.04 / Centos 7
  • Inventory: services.thirdparties.source with self-signed certificate.

Steps:

  1. Run check_iaas --tasks software.thirdparties.availability

Results:

Before After
Check fails Check succeeds

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

@ilia1243 ilia1243 added the improvement New feature or request label Apr 10, 2024
@ilia1243 ilia1243 requested a review from Imadzuma April 10, 2024 09:35
@ilia1243 ilia1243 force-pushed the bugfix/thirdparties_skip_ssl_verify branch from c7cda7a to e2c1b4c Compare April 12, 2024 11:13
@koryaga koryaga merged commit ac85cbd into main Apr 15, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants