Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPREQ-8729] Improve paas_check_detected_incorrect_packages_versions_explanation #609

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

nikhil1697
Copy link
Collaborator

@nikhil1697 nikhil1697 commented Feb 29, 2024

Description

The modification enhances the formatting of messages appended to the bad_results list within the check_packages_versions function.
*

Fixes # (issue)
https://tms.netcracker.com/browse/CPREQ-8729

Solution

The solution involves adjusting the format of the appended message to the bad_results list.
*

Test Cases

TestCase 1

Steps:

  1. Upgrade the containerd version from 1.6.* to 1.7.*
  2. Run K=kubemarine check_paas

Results:

Before After
Check the presence and correctness of the version of the following packages on the system: ['containerd=1.7.2-0ubuntu1~20.04.1'] Check the presence and correctness of the version of the following packages on the system: ['containerd=1.6.* (Actual version: containerd=1.7.2-0ubuntu1~20.04.1, Expected package version: containerd=1.6.)']

|

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

Unit tests

Indicate new or changed unit tests and what they do, if any.

@nikhil1697 nikhil1697 requested a review from koryaga February 29, 2024 18:55
@nikhil1697 nikhil1697 added the improvement New feature or request label Feb 29, 2024
@nikhil1697 nikhil1697 self-assigned this Feb 29, 2024
@koryaga koryaga changed the title CPREQ-8729_Improve paas_check_detected_incorrect_packages_versions_explanation [CPREQ-8729] Improve paas_check_detected_incorrect_packages_versions_explanation Mar 4, 2024
@nikhil1697 nikhil1697 requested a review from ilia1243 March 7, 2024 08:27
@nikhil1697 nikhil1697 requested a review from ilia1243 March 11, 2024 07:15
@koryaga koryaga merged commit acdfd84 into main Mar 11, 2024
42 checks passed
@koryaga koryaga deleted the CPREQ-8729_Improve_paas_check branch March 11, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants