Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPDEV-98324] Disable package automatic discovery of setuptools #602

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

ilia1243
Copy link
Contributor

Description

  • If Kubemarine is run from sources and dump/ directory is created, attempt to build the package fails with
    Multiple top-level packages discovered in a flat-layout: ['dump', 'kubemarine']

Solution

  • Disable package automatic discovery by explicitly specifying where to search the packages in.

Test Cases

TestCase 1

Steps:

  1. Run Kubemarine from sources
  2. Install package from sources using pip install .

Results:

Before After
Multiple top-level packages discovered in a flat-layout: ['dump', 'kubemarine'] Package is built successfully

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

@ilia1243 ilia1243 added the bug Something isn't working label Feb 19, 2024
@koryaga koryaga self-requested a review February 19, 2024 07:38
@koryaga koryaga merged commit a45bbf2 into main Feb 19, 2024
41 checks passed
@koryaga koryaga deleted the bugfix/build_package_extra_directories branch February 19, 2024 10:11
@vlar0816 vlar0816 changed the title Disable package automatic discovery of setuptools [CPDEV-98324] Disable package automatic discovery of setuptools Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants