Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements and fixes in GitHub workflows #591

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Improvements and fixes in GitHub workflows #591

merged 4 commits into from
Jan 26, 2024
+19 −9

Conversation

ilia1243
Copy link
Contributor

@ilia1243 ilia1243 commented Jan 25, 2024 •
edited
Loading

Description

  • thirdparties_sync workflow does not work. Due to this, some original plugin manifests are incorrect.
  • There is no early check that Kubemarine is runnable on a range of python versions.

Solution

  • Fix thirdparties_sync workflow.
  • Change manifest for nginx-ingress-controller v1.8.1 to make it the same as original.
  • Added running of mypy on all supported python versions except 3.7

Test Cases

Try to manually change plugin manifest.

TestCase 1

Steps:

  1. Change any plugin manifest in kubemarine/plugins/yaml
  2. Commit and push the changes.

ER: thirdparties_sync workflow fails.
AR: the workflow did not fail.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

@ilia1243 ilia1243 added the bug Something isn't working label Jan 25, 2024
@ilia1243 ilia1243 merged commit 82cdfcf into main Jan 26, 2024
40 checks passed
@ilia1243 ilia1243 deleted the improvement/workflow_fixes_and_improvements branch January 26, 2024 13:35
koryaga pushed a commit that referenced this pull request Jan 26, 2024
@ilia1243 @koryaga
Improvements and fixes in GitHub workflows (#591)
3ddbd58 
* Fix collecting events if integration tests are failed

* Make manifests original

* Fix check that manifests are not changed manually

* Run mypy on all python versions
koryaga added a commit that referenced this pull request Jan 30, 2024
@ilia1243 @koryaga
[CPDEV-97376] Support of Kubernetes v1.29.1 (#576)
94eb677 
* Implement kube-proxy reconfiguration

* Add services.kubeadm_kube-proxy.conntrack.min property

Reconfigure conntrack.min during upgrade.

* Support renew super-admin cert

* Support Kubernetes v1.29.0

* k8s v1.29.1
calico v3.27.0
ingress v1.9.5
crictl v1.29.0
localpach provisioner v0.0.26

* update test

* fix test

* Improvements and fixes in GitHub workflows (#591)

* Fix collecting events if integration tests are failed

* Make manifests original

* Fix check that manifests are not changed manually

* Run mypy on all python versions

* Add supported versions doc for v1.29.1

* Workaround kubernetes/ingress-nginx#10942

---------

Co-authored-by: sergey kryazhev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koryaga koryaga koryaga approved these changes

Assignees

@koryaga koryaga

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilia1243 @koryaga