Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduler's patch name #590

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Fix scheduler's patch name #590

merged 1 commit into from
Jan 25, 2024

Conversation

n549
Copy link
Contributor

@n549 n549 commented Jan 25, 2024

Description

There was a typo in the name of the file with scheduler's patch: kube-scheduler_json.json instead of kube-scheduler+json.json

Fixes # (issue)

Solution

The typo is fixed.

How to apply

Test Cases

Deploy kubernetes with some kube-scheduler's customization, for example:

service:
  kubeadm_patches:
    scheduler:
    - groups: [control-plane]
      patch:
        log-flush-frequency: 20s 

ER: kube-scheduler's manifest at the master nodes contains the new log-flush-frequency duration value.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

Unit tests

Indicate new or changed unit tests and what they do, if any.

@n549 n549 added the bug Something isn't working label Jan 25, 2024
@n549 n549 requested a review from ilia1243 January 25, 2024 07:23
@koryaga koryaga merged commit 588e532 into main Jan 25, 2024
36 checks passed
@koryaga koryaga deleted the fix_kubeadm_patch_names branch January 25, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants