Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPDEV-95920] Support KubeProxyConfiguration as services.kubeadm_kube-proxy section #571

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

ilia1243
Copy link
Contributor

@ilia1243 ilia1243 commented Dec 8, 2023

Description

Solution

  • Added services.kubeadm_kube-proxy that directly converted to the KubeProxyConfiguration for kubeadm init.

Test Cases

TestCase 1

Configure custom properties in services.kubeadm_kube-proxy.

Steps:

  1. Configure custom properties in services.kubeadm_kube-proxy and install the cluster.

ER: The properties are handled respectively. Check at least kubectl get cm -n kube-system kube-proxy -o yaml.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

@ilia1243 ilia1243 force-pushed the feature/kubeadm_kube-proxy branch from 8f6c84f to 6e8e7fb Compare December 8, 2023 08:49
@alexarefev
Copy link
Collaborator

Sorry, but I did not realize how the kube-proxy custom parameters are reflected in kube-proxy configMap

@ilia1243
Copy link
Contributor Author

ilia1243 commented Dec 12, 2023

Sorry, but I did not realize how the kube-proxy custom parameters are reflected in kube-proxy configMap

They are passed as KubeProxyConfiguration to kubeadm init using kubernetes.get_kubeadm_config() https://github.com/Netcracker/KubeMarine/pull/571/files#diff-06f6e567fbbc6e8f10df941795f81ed273577ac92778a9e67c6b52be1a65fbbe

kubeadm will manage itself how to fill kube-proxy configMap

@alexarefev
Copy link
Collaborator

alexarefev commented Dec 12, 2023

Sorry, but I did not realize how the kube-proxy custom parameters are reflected in kube-proxy configMap

They are passed as KubeProxyConfiguration to kubeadm init using kubernetes.get_kubeadm_config() https://github.com/Netcracker/KubeMarine/pull/571/files#diff-06f6e567fbbc6e8f10df941795f81ed273577ac92778a9e67c6b52be1a65fbbe

kubeadm will manage itself how to fill kube-proxy configMap

So, what is the way to change kube-proxy configuration after the installation procedure?

@ilia1243
Copy link
Contributor Author

ilia1243 commented Dec 12, 2023

Sorry, but I did not realize how the kube-proxy custom parameters are reflected in kube-proxy configMap

They are passed as KubeProxyConfiguration to kubeadm init using kubernetes.get_kubeadm_config() https://github.com/Netcracker/KubeMarine/pull/571/files#diff-06f6e567fbbc6e8f10df941795f81ed273577ac92778a9e67c6b52be1a65fbbe
kubeadm will manage itself how to fill kube-proxy configMap

So, what is the way to change kube-proxy configuration after the installation procedure?

No way, as much as there is no way to change any custom configuration managed by kubeadm after the installation procedure.

@vlar0816 vlar0816 changed the title Support KubeProxyConfiguration as services.kubeadm_kube-proxy section [CPDEV-95723] Support KubeProxyConfiguration as services.kubeadm_kube-proxy section Dec 12, 2023
@vlar0816 vlar0816 changed the title [CPDEV-95723] Support KubeProxyConfiguration as services.kubeadm_kube-proxy section [CPDEV-95920] Support KubeProxyConfiguration as services.kubeadm_kube-proxy section Dec 13, 2023
@koryaga koryaga merged commit b187624 into main Dec 15, 2023
@koryaga koryaga deleted the feature/kubeadm_kube-proxy branch December 15, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants