Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPDEV-93171] - clean kubernetes tmp dir before upgrade #557

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

Imadzuma
Copy link
Contributor

Description

During upgrade procedure kubeadm creates special backup files, that are used for manual restoration.
But no one uses or cleans those files, for this reason they are not really needed and only take up the place on the disk.

Fixes # (issue)

Solution

  • Added the special task, that cleans up that directory before upgrade procedure; As result backups only for the last upgrade will be in that directory after the procedure;
  • Added information about it in documentation;

Test Cases

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any

TestCase 1

Test Configuration:

  • Hardware:
  • OS:
  • Inventory:

Steps:

  1. run kubemarine install;
  2. run kubemarine upgrade to one version;
  3. check content of /etc/kubernetes/tmp folder on worker and control-plane nodes;
  4. run kubemarine upgrade again to another version;
  5. check content of /etc/kubernetes/tmp folder again on worker and control-plane nodes;
    Results:
Before After
files from step 3 are visible for step 5 step 3 and step 5 have different backup files

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

Unit tests

Indicate new or changed unit tests and what they do, if any.

@koryaga koryaga requested a review from ilia1243 November 27, 2023 08:51
@koryaga koryaga self-assigned this Nov 27, 2023
@koryaga koryaga added the bug Something isn't working label Nov 27, 2023
@koryaga koryaga requested review from n549 and alexarefev November 27, 2023 08:53
@Imadzuma Imadzuma requested a review from alexarefev November 29, 2023 07:32
@koryaga koryaga requested a review from shmo1218 November 29, 2023 13:07
@koryaga
Copy link
Contributor

koryaga commented Nov 29, 2023

@shmo1218 pls update afterwards

@koryaga koryaga merged commit 95ccc08 into main Nov 29, 2023
@koryaga koryaga deleted the CPDEV-93171_cleanup-tmp-upgrade branch November 29, 2023 13:08
@Imadzuma Imadzuma mentioned this pull request Nov 30, 2023
5 tasks
@shmo1218 shmo1218 mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants