[CPDEV-93591] Expose Calico Typha metrics #517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solution
How to apply
Run
kubemarine migrate_kubemarine --force-apply calico_typha_metrics
Test Cases
TestCase 1
Install cluster with monitoring.
Steps:
calico.typha=enabled
.Results:
calico-node
,calico-kube-controllers
,calico-typha
are collectedTestCase 2
Migrate Kubemarine, enable metrics for calico-typha.
Steps:
calico.typha=enabled
using old version of Kubemarine.kubemarine migrate_kubemarine --force-apply calico_typha_metrics
using new version of Kubemarine.ER: metrics are collected for all calico services.
Checklist
Unit tests
test_calico.py - cover changed enrichment of calico manifest
test_builtin.py - cover internal API in builtin.py.