Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MANOPD-86838] Resolve conflict of archive names in add_node and restore procedures #402

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

ilia1243
Copy link
Contributor

@ilia1243 ilia1243 commented Mar 31, 2023

Description

  • restore after add_node fails with "[Errno 13] Permission denied"
  • The reason is in '/tmp/kubemarine-backup.tar.gz' archive that is left after add_node procedure, belongs to root, and prevents uploading of different archive with the same name during restore.

Solution

  • Use archives with different names for different purposes.

Test Cases

TestCase 1

Steps:

  1. Run install, then backup, then remove_node & add_node, then restore.

Results:

Before After
"[Errno 13] Permission denied" Successful

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

@ilia1243 ilia1243 added the bug Something isn't working label Mar 31, 2023
@ilia1243 ilia1243 requested a review from dmyar21 March 31, 2023 07:36
@ilia1243 ilia1243 assigned koryaga and ilia1243 and unassigned ilia1243 Mar 31, 2023
@ilia1243 ilia1243 force-pushed the bugfix/tmp_file_conflict_add_node_restore branch from 4804d44 to 94c14b3 Compare March 31, 2023 07:40
@koryaga koryaga changed the title MANOPD-86838 Resolve conflict of archive names in add_node and restore procedures [MANOPD-86838] Resolve conflict of archive names in add_node and restore procedures Mar 31, 2023
@koryaga koryaga requested a review from n549 March 31, 2023 08:07
@koryaga koryaga merged commit 9d41bf8 into main Mar 31, 2023
@koryaga koryaga deleted the bugfix/tmp_file_conflict_add_node_restore branch March 31, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants