Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase deployments.expect.retries #380

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

n549
Copy link
Contributor

@n549 n549 commented Mar 9, 2023

Description

Old value of deployments.expect.retries (30) is not enough to calico daemonset get up.

Fixes # (issue)

Solution

change deployments.expect.retries to 45 as it were for pods.expect.plugins.retries.

How to apply

Test Cases

Run install job with tasks=deploy.plugins.
ER: plugins are installed successfully, timeout for daemonsets, deployments, statefulsets is 5*45=220s.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

Unit tests

Indicate new or changed unit tests and what they do, if any.

@n549 n549 requested a review from OleksandrIaresko March 9, 2023 07:07
@koryaga koryaga added the bug Something isn't working label Mar 9, 2023
@koryaga koryaga added this to the 0.14.0 milestone Mar 9, 2023
@koryaga koryaga merged commit 4327abc into main Mar 9, 2023
@koryaga koryaga deleted the increase_deployments_timeout branch March 9, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants