-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MANOPD-83734 Actualize and ensure mandatory thirdparty packages #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imadzuma
reviewed
Jan 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also exclude packages to install from ci/default_config.yaml
to handle case with mandatory packages from CI
Done |
d1a112f
to
a19a1d5
Compare
koryaga
approved these changes
Jan 25, 2023
@shmo1218 pls proceed |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solution
iptables
to the list of mandatory packages.semanage
is installed only on RHEL nodes.unzip
is installed only if it is required byservices.thirdparties
.conntrack
,iptables
are installed only on control-plane, worker nodes.openssl
,curl
, andkmod
packages are installed on all nodes.prepare.package_manager.manage_packages
task.services.packages.mandatory
section that allows to turn mandatory packages off.mandatory_packages_off
patch of existing inventories to turn automatic managing of mandatory packages off for backward compatibility.upgrade
procedure. Now it allows packages associations only fordocker
andcontainerd
because there is no process to upgrade other system packages. It now also prohibitspackage_manager
section.globals.yaml
for deduplication.check_iaas
checks that mandatory packages are available.check_paas
to check that audit and mandatory packages have equal versions on the relevant nodes.How to apply
Run
migrate_kubemarine --force-apply mandatory_packages_off
Test Cases
TestCase 1
Test Configuration:
services.packages.install
section.Steps:
install
.Results:
deploy.kubernetes.init
task.TestCase 2
Test Configuration:
services.packages.mandatory
.Steps:
install
.Results:
TestCase 3
Test Configuration:
Steps:
kubemarine_migrate --force-apply mandatory_packages_off
.Results:
TestCase 4
Test Configuration:
Steps:
Results:
cluster_finalized.yaml
.TestCase 5
Test Configuration:
Steps:
check_iaas
,check_paas
.Results:
check_iaas
checks that mandatory packages are available in repositories.check_paas
checks that mandatory packages and audit have equal versions.Checklist
Unit tests
test_executor.py - added tests for minor fixes/improvements of RemoteExecutor.
test_audit.py - added tests for installation on centos.
test_install.py - new tests for mandatory packages installation.
test_packages.py - added tests for improved packages versions detection, including support of mandatory packages.