Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PSUPCLPL-11428] Update defaults.yaml and global.yaml - parametrize local-path-provisioner and busybox image version #326

Merged
merged 3 commits into from
Jan 11, 2023

Conversation

n549
Copy link
Contributor

@n549 n549 commented Dec 29, 2022

Description

Versions for local-path-provisioner and busybox are set in globals.yaml depending on k8s versions. On the other hand local-path-provisioner and busybox image version is hardcoded in defaults.yaml

Fixes # (issue)
PSUPCLPL-11428

Solution

image version for local-path-provisioner and busybox in default.yaml set parametrized, depending on versions in globals.yaml

How to apply

Test Cases

  1. Deploy local-path-provisioner in k8s v1.25
    ER: local-path-provisioner v0.0.23 is deployed.

  2. Deploy local-path-provisioner in k8s < v1.25
    ER: local-path-provisioner v0.0.22 is deployed.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

Unit tests

@n549 n549 added the bug Something isn't working label Dec 29, 2022
@n549 n549 requested review from Imadzuma and dmyar21 December 29, 2022 07:56
@dmyar21 dmyar21 force-pushed the PSUPCLPL-11428_fix_local-path-provisioner_version branch from 6c1d7a3 to 7127184 Compare January 10, 2023 13:03
@dmyar21 dmyar21 changed the title [PSUPCLPL-11428] Update defaults.yaml - parametrize local-path-provisioner image version [PSUPCLPL-11428] Update defaults.yaml and global.yaml - parametrize local-path-provisioner and busybox image version Jan 10, 2023
@koryaga koryaga merged commit 09a6248 into main Jan 11, 2023
dmyar21 added a commit that referenced this pull request Jan 19, 2023
…ocal-path-provisioner and busybox image version (#326)

* fix compatibility_map

* fix compatibility_map

* fix compatibility_map

Co-authored-by: Dmitry Yarovov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants