Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MANOPD-76880] Fix cache package version #181

Merged
merged 5 commits into from
Jun 28, 2022
Merged

[MANOPD-76880] Fix cache package version #181

merged 5 commits into from
Jun 28, 2022

Conversation

alexarefev
Copy link
Collaborator

@alexarefev alexarefev commented Jun 17, 2022

Description

  • cache_version options does not work for packages from 'associations' section. For instance: add_node procedure does not fail if there are several versions of the containerd package in the cluster.

Fixes # [MANOPD-76880]

Solution

  • Change detecting packages versions procedure to use regexp to distinguish package name

How to apply

Not applicable

Test Cases

TestCase 1
cache_versions: true works properly during add_node procedure

Test Configuration:

  • Hardware: 4CPU/8GB
  • OS: Ubuntu 20.04; CentOS7
  • Inventory: fullHA

Steps:

  1. Install cluster.
  2. Upgrade containerd package on one node up to version that has different minor (eg. 1.4 becomes 1.5)
  3. Run add_node procedure.

Results:

Before After
Success Fail

TestCase 2
cache_versions: false works properly during add_node procedure.

Test Configuration:

  • Hardware: 4CPU/8GB
  • OS: Ubuntu 20.04; CentOS7
  • Inventory: fullHA

Steps:

  1. Install cluster.
  2. Upgrade containerd package on one node up to version that has different minor (eg. 1.4 becomes 1.5)
  3. Run add_node procedure.

Results:

Before After
Success; Installed version comes from associations section Success; Installed version is latest

TestCase 3
package.associations in cluster.yaml works properly during add_node procedure.

Test Configuration:

  • Hardware: 4CPU/8GB
  • OS: Ubuntu 20.04; CentOS7
  • Inventory: fullHA

Steps:

  1. Install cluster. cluster.yaml should have package.associations and cache_versions: false
  2. Upgrade containerd package on one node up to version that has different minor (eg. 1.4 becomes 1.5)
  3. Run add_node procedure.
  4. Change cache_versions: true in cluster.yaml.
  5. Run add_node procedure.

Results:

Before After
Success; Installed version is latest Success; Installed version comes from associations section
Fail Success; Installed version comes from associations section

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

@koryaga koryaga marked this pull request as draft June 17, 2022 08:40
@koryaga koryaga self-assigned this Jun 20, 2022
@koryaga koryaga added bug Something isn't working and removed draft labels Jun 20, 2022
@koryaga koryaga marked this pull request as ready for review June 21, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants