feat: rest framework enhancements #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulguptajss
requested review from
cdurai-netapp,
cgrinds and
Hardikl
as code owners
cgrinds
reviewed
Jan 18, 2022
cmd/collectors/rest/rest.go
Outdated
| r.Logger.Error().Err(err).Str("key", key).Str("metric", metric.GetName()). | ||
| Msg("Unable to set float key on metric") | ||
| if metr, ok := r.Matrix.GetMetrics()[metric.name]; !ok { | ||
| if metr, _ = r.Matrix.NewMetricFloat64(metric.name); err != nil { |
There was a problem hiding this comment.
would be slightly clearer to 1) create the metric by name and 2) update the map in this block and then remove the else and use it for both cases
cmd/collectors/rest/rest.go
Outdated
| if f.Exists() { | ||
| if metr, ok := data.GetMetrics()[metric]; !ok { | ||
| if metr, _ = data.NewMetricFloat64(metric); err != nil { | ||
| if metr, ok := data.GetMetrics()[metric.name]; !ok { |
There was a problem hiding this comment.
similar comment as above about minor refactoring
Hardikl
reviewed
Jan 18, 2022
cmd/collectors/rest/rest.go
Outdated
| r.Logger.Error().Err(err).Str("key", key).Str("metric", metric.GetName()). | ||
| Msg("Unable to set float key on metric") | ||
| if metr, ok := r.Matrix.GetMetrics()[metric.name]; !ok { | ||
| if metr, _ = r.Matrix.NewMetricFloat64(metric.name); err != nil { |
cgrinds
reviewed
Jan 18, 2022
| Msg("NewMetricFloat64") | ||
| } | ||
| } | ||
| f := instanceData.Get(metric.name) |
There was a problem hiding this comment.
when err != nil is metr valid to use below?
| Msg("NewMetricFloat64") | ||
| } | ||
| } | ||
| f := instanceData.Get(metric.name) |
There was a problem hiding this comment.
when err != nil, is metr valid?
There was a problem hiding this comment.
metr is not added to matrix if there is an error. In current case, we check for duplicates.
cgrinds
reviewed
Jan 18, 2022
cgrinds
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.