Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rest infrastructure #565

Merged
merged 8 commits into from
Nov 2, 2021
Merged

feat: rest infrastructure #565

merged 8 commits into from
Nov 2, 2021

Conversation

rahulguptajss
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 13, 2021
@rahulguptajss rahulguptajss linked an issue Oct 14, 2021 that may be closed by this pull request
@rahulguptajss rahulguptajss force-pushed the rg2-rest-infrastructure branch 6 times, most recently from 17842ed to bb56c42 Compare October 25, 2021 14:11
Copy link
Collaborator

@cgrinds cgrinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job @rahulguptajss

cmd/collectors/rest/rest.go Outdated Show resolved Hide resolved
cmd/collectors/rest/rest.go Outdated Show resolved Hide resolved
cmd/collectors/rest/rest.go Outdated Show resolved Hide resolved
cmd/collectors/rest/rest.go Outdated Show resolved Hide resolved
cmd/collectors/rest/rest.go Show resolved Hide resolved
cmd/collectors/rest/templating.go Outdated Show resolved Hide resolved
cmd/tools/rest/client.go Outdated Show resolved Hide resolved
cmd/tools/rest/client.go Outdated Show resolved Hide resolved
cmd/tools/rest/client.go Outdated Show resolved Hide resolved
pkg/util/util.go Outdated Show resolved Hide resolved
@rahulguptajss rahulguptajss force-pushed the rg2-rest-infrastructure branch from 83bcbb0 to 7ca517b Compare October 28, 2021 09:14
@rahulguptajss
Copy link
Contributor Author

I have squashed commits to single one. I'll resolve the comments tomorrow.

Copy link
Contributor

@Hardikl Hardikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we removed ?(bool) from yaml, we can remove logic from go as well.

cmd/collectors/rest/plugins/disk/disk.go Outdated Show resolved Hide resolved
cmd/collectors/rest/rest.go Outdated Show resolved Hide resolved
conf/rest/9.13.0/node.yaml Outdated Show resolved Hide resolved
conf/zapi/cdot/9.8.0/spare.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@cgrinds cgrinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Two minor logging issues and then merge

cmd/collectors/rest/rest.go Outdated Show resolved Hide resolved
cmd/collectors/rest/rest.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@cgrinds cgrinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @rahulguptajss

@cgrinds cgrinds merged commit 95b6104 into main Nov 2, 2021
@cgrinds cgrinds deleted the rg2-rest-infrastructure branch November 2, 2021 12:56
@rahulguptajss rahulguptajss linked an issue Dec 3, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: implement REST-based collector for ONTAP Add REST support to Harvest
3 participants