Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Template docs #555

Merged
merged 6 commits into from
Oct 18, 2021
Merged

feat: Template docs #555

merged 6 commits into from
Oct 18, 2021

Conversation

rahulguptajss
Copy link
Contributor

Fixes #493

Hardikl
Hardikl previously approved these changes Oct 11, 2021
conf/README.md Outdated Show resolved Hide resolved
Hardikl
Hardikl previously approved these changes Oct 11, 2021
Copy link
Collaborator

@cgrinds cgrinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like this conf/README.md

conf/README.md Show resolved Hide resolved
conf/README.md Outdated Show resolved Hide resolved
conf/README.md Outdated Show resolved Hide resolved
conf/README.md Outdated Show resolved Hide resolved
conf/README.md Outdated Show resolved Hide resolved
conf/README.md Outdated Show resolved Hide resolved
conf/README.md Outdated Show resolved Hide resolved
conf/README.md Outdated
- application
```

Harvest will merge these templates during poller start and merged template will be as below
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harvest will merge your new template conf/zapi/cdot/9.8.0/custom_lun.yaml with the out-of-the-box conf/zapi/cdot/9.8.0/lun.yaml one resulting in a combined template like this:

conf/README.md Outdated Show resolved Hide resolved
conf/README.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@rahulguptajss rahulguptajss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@cgrinds cgrinds merged commit 19b8f14 into main Oct 18, 2021
@cgrinds cgrinds deleted the rg2-template-merge-doc branch October 18, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template merge functionality
3 participants